[flang] Check coranks on MOVE_ALLOC #129944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FROM= and TO= arguments in a reference to the MOVE_ALLOC intrinsic subroutine must have the same corank.
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) ChangesThe FROM= and TO= arguments in a reference to the MOVE_ALLOC intrinsic subroutine must have the same corank. Full diff: https://github.com/llvm/llvm-project/pull/129944.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-call.cpp b/flang/lib/Semantics/check-call.cpp
index ecc1e3d27e3bf..e3c716fce4ebb 100644
--- a/flang/lib/Semantics/check-call.cpp
+++ b/flang/lib/Semantics/check-call.cpp
@@ -1840,6 +1840,13 @@ static void CheckMove_Alloc(evaluate::ActualArguments &arguments,
if (arguments.size() >= 2) {
evaluate::CheckForCoindexedObject(
messages, arguments[1], "move_alloc", "to");
+ int fromCR{GetCorank(arguments[0])};
+ int toCR{GetCorank(arguments[1])};
+ if (fromCR != toCR) {
+ messages.Say(*arguments[0]->sourceLocation(),
+ "FROM= argument to MOVE_ALLOC has corank %d, but TO= argument has corank %d"_err_en_US,
+ fromCR, toCR);
+ }
}
if (arguments.size() >= 3) {
evaluate::CheckForCoindexedObject(
diff --git a/flang/test/Semantics/move_alloc.f90 b/flang/test/Semantics/move_alloc.f90
index 3303a002039bb..73db594129eab 100644
--- a/flang/test/Semantics/move_alloc.f90
+++ b/flang/test/Semantics/move_alloc.f90
@@ -1,7 +1,7 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
! Check for semantic errors in move_alloc() subroutine calls
program main
- integer, allocatable :: a(:)[:], b(:)[:], f(:), g(:)
+ integer, allocatable :: a(:)[:], b(:)[:], f(:), g(:), h(:)[:,:]
type alloc_component
integer, allocatable :: a(:)
end type
@@ -73,4 +73,7 @@ program main
!ERROR: Argument #2 to MOVE_ALLOC must be allocatable
call move_alloc(f, g(::2))
+ !ERROR: FROM= argument to MOVE_ALLOC has corank 1, but TO= argument has corank 2
+ call move_alloc(a, h)
+
end program main
|
eugeneepshteyn
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FROM= and TO= arguments in a reference to the MOVE_ALLOC intrinsic subroutine must have the same corank.